-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major Documentation Revamp #134
Conversation
I am also replacing the deprecated functions in the documentation. So, far I have finished |
`author` maybe?
…On Sun, Mar 17, 2019 at 9:06 AM Ayush Kaushal ***@***.***> wrote:
@aviks <https://github.com/aviks> I was going through the docs. I found
that names
<https://github.com/JuliaText/TextAnalysis.jl/blob/b3c467cebb776c6a7e686cfe2b6c9a20c2ca2205/src/metadata.jl#L32>
(used for setting metadata - author name for entire corpus of docs),
conflicts with the base refer (v0.7)
<https://docs.julialang.org/en/v0.7/base/base/#Base.names> and (v1)
<https://docs.julialang.org/en/v1/base/base/#Base.names>. What do you
suggest about this? Should I open an issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXIJuB1qmtFTXVLGmXZV1DwMdYi5POJks5vXgWRgaJpZM4b3U1e>
.
|
A correction - Author/authors is already used for document's author, should I change the metadata containing the document name to |
The following are the metadata - This is also missing from the documentation for accessing the corpus metadata, I am adding it. |
|
|
I think that maybe we can start by opening an issue of what all major changes are to be done for TextAnalysis.jl, taking into consideration the things mentioned in the conversation above. |
@aviks Can you please suggest your views on this, so that I may proceed accordingly. |
Thanks Ayush, this looks good. Let me know once this is ready to merge. I'm happy to merge things over from StringAnalysis if Corneliu is ok with that. |
@aviks I'm perfectly fine with this; feel free to port to |
Separate one please
…On Mon, 18 Mar 2019, 18:48 Ayush Kaushal, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/src/corpus.md
<#134 (comment)>
:
> @@ -83,3 +139,56 @@ corpus. The easiest way to do this is to convert a `Corpus` object into
a `DataFrame`:
convert(DataFrame, crps)
+
+## Corpus Metadata
+
+You can also retrieve the metadata for every document in a `Corpus` at once:
+
+* `languages()`: What language is the document in? Defaults to `Languages.English()`, a Language instance defined by the Languages package.
+* `names()`: What is the name of the document? Defaults to `"Unnamed Document"`.
Do you prefer that I send another PR making changes, name -> title & name!
-> title! & names -> titles & names! to titles! (across the entire
codebase, including tests, docs) ? Or include in this one itself?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXIJswvIK-wRXsrqwkjVruj7A05Stdaks5vX9-NgaJpZM4b3U1e>
.
|
56fdd52
to
f4b5561
Compare
@aviks Do you think, BM25 and Co-occurrence matrix will be a good addition to TextAnalysis.jl? |
Yes please! |
This PR is aimed at improving the docs in the following ways -
Also testing for the possible errors in the package.
Progress