allow multiple ngram complexity in NGramDocument, ngrams and ngrammize #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviks
reviewed
May 22, 2019
| @@ -81,18 +81,17 @@ TokenDocument(txt::AbstractString) = TokenDocument(String(txt), DocumentMetadata | |||
|
|
|||
| mutable struct NGramDocument{T<:AbstractString} <: AbstractDocument | |||
| ngrams::Dict{T,Int} | |||
| n::Int | |||
| n::Union{Int,Vector{Int}} | |||
There was a problem hiding this comment.
Would this defeat type inference?
There was a problem hiding this comment.
I don't seen ngram_complexity (or this field) used anywhere in TextAnalysis. It may be used from external code. But then there are no abstracts here, and it should be easy to make them type stable if/where needed.
Allow NGramDocument to optionally store ngrams of multiple ngram complexity. Updated `ngrams` and `ngramize` methods to generate such ngrams. Updated corresponding docs and added tests. Also corrected `show` method for `NGramDocument`.
|
rebased to fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
NGramDocumentto optionally store ngrams of multiple ngram complexity. Updatedngramsandngramizemethods to generate such ngrams. Updated corresponding docs and added tests.Also corrected
showmethod forNGramDocument.Ref: #148 and #148 (comment)