-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional Random Fields #162
Conversation
Ayushk4
commented
Jun 14, 2019
•
edited
Loading
edited
- Viterbi Decode
- Supports for training with Flux Layers
- Documentation
- Tests
- Extended example over the Flux layers
Seems fine to me code style wise; @aviks don't know if you want any deeper look over this, but it's not a model I'm really familiar with. Could probably use some tests / a usage demo but you have that listed. If this is something that's designed to be trained by users, rather than classifying things out of the box, maybe there's a case for just having it in Flux itself? You might want to look at |
@aviks Please review this PR. |
I'm merging this here for now. It may be worth moving to Flux, but I don't want to make that a blocker for further work. Ayush, you may want to make a PR to Flux at some point with this model, but it's not urgent. |