Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for Part of Speech Tagging #169

Merged
merged 10 commits into from
Aug 26, 2019
Merged

Add API for Part of Speech Tagging #169

merged 10 commits into from
Aug 26, 2019

Conversation

Ayushk4
Copy link
Member

@Ayushk4 Ayushk4 commented Aug 19, 2019

  • DataDeps
  • API over String, tokens (Array of string), Document types and Corpus
  • Tests
  • Documentation

Copy link
Member

@aviks aviks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/TextAnalysis.jl Outdated Show resolved Hide resolved
src/sequence/pos.jl Outdated Show resolved Hide resolved
src/sequence/pos_datadeps.jl Show resolved Hide resolved
@aviks
Copy link
Member

aviks commented Aug 23, 2019

Is this ready to be merged?

@Ayushk4
Copy link
Member Author

Ayushk4 commented Aug 23, 2019

Yes, it is ready from my side. Please give any more suggestions you may have regarding the patch.

@aviks aviks merged commit 10aa51a into JuliaText:master Aug 26, 2019
@Ayushk4
Copy link
Member Author

Ayushk4 commented Jan 19, 2020

This PR addressed #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants