Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic tests #11

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Add basic tests #11

merged 1 commit into from
Aug 12, 2023

Conversation

omus
Copy link
Member

@omus omus commented Aug 12, 2023

Adds some basic tests including:

  • Validating the parsed TZDATA_VERSION is what we expect
  • The compiled tzjfile data can be loaded by TimeZones.jl

using Test

# TODO: Can be removed once this is in an official TimeZones release
Copy link
Member Author

@omus omus Aug 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release this will be included in is TimeZones.jl 1.12.0 (JuliaTime/TimeZones.jl#441). Unfortunately, that release is blocked on a 1.0 release of this package which I'd like to have include these tests. We'll merge these tests as is.

@omus omus merged commit e6a7bdb into main Aug 12, 2023
3 checks passed
@omus omus deleted the cv/tests branch August 12, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant