Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul printing of types #194

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Overhaul printing of types #194

merged 2 commits into from
Mar 29, 2019

Conversation

omus
Copy link
Member

@omus omus commented Mar 29, 2019

Should allow repr to display the program representation of the instances. Related to these Dates stdlib changes:

Related to these Dates stdlib changes:

- JuliaLang/julia#30200
- JuliaLang/julia#30817
@omus omus requested a review from iamed2 March 29, 2019 17:25
test/helpers.jl Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #194 into master will increase coverage by 0.42%.
The diff coverage is 97.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   91.86%   92.29%   +0.42%     
==========================================
  Files          30       30              
  Lines        1070     1103      +33     
==========================================
+ Hits          983     1018      +35     
+ Misses         87       85       -2
Impacted Files Coverage Δ
src/io.jl 100% <100%> (+13.04%) ⬆️
src/discovery.jl 83.56% <100%> (ø) ⬆️
src/utcoffset.jl 96% <80%> (-4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 870702b...580cbf1. Read the comment docs.

@omus omus merged commit c57e8e3 into master Mar 29, 2019
@omus omus deleted the cv/printing-overhaul branch May 17, 2019 18:17
kpamnany pushed a commit to RelationalAI-oss/TimeZones.jl that referenced this pull request May 5, 2023
* Overhaul printing of types

Related to these Dates stdlib changes:

- JuliaLang/julia#30200
- JuliaLang/julia#30817

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants