Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining issues #14

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Fix remaining issues #14

merged 5 commits into from
Jun 11, 2024

Conversation

pat-alt
Copy link
Member

@pat-alt pat-alt commented Jun 10, 2024

  • gradients in mcmc_samples should be computed for batches, not the whole dataset.
  • for this to work, it probably does not make sense to have inputs as part of model.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (50c1fd6) to head (3f4ff73).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   94.35%   94.85%   +0.49%     
==========================================
  Files           5        5              
  Lines         124      136      +12     
==========================================
+ Hits          117      129      +12     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pat-alt pat-alt merged commit 9c1ddd3 into main Jun 11, 2024
5 checks passed
@pat-alt pat-alt deleted the fix-samplers branch June 11, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant