Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths in parallel VTK files are now relative to that file #141

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

jipolanco
Copy link
Member

When writing a parallel VTK file (such as a .pvtu) to a relative directory dir/ other than ., the paths in that file are now relative to dir instead of ..

This doesn't change anything when absolute paths are used.

Closes #139

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.87%. Comparing base (7eb6761) to head (9836771).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   96.84%   96.87%   +0.03%     
==========================================
  Files          15       15              
  Lines         856      865       +9     
==========================================
+ Hits          829      838       +9     
  Misses         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jipolanco jipolanco merged commit bdb309e into master Apr 4, 2024
7 checks passed
@jipolanco jipolanco deleted the pvtk-relpath branch April 4, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relative file paths & field data with parallel file formats
1 participant