Add HTTP.removeheader and some missing getparam(s) tests (#883)

* Add HTTP.removeheader and some missing getparam(s) tests

* fix tests

* fix getparam export

docs/src/reference.md

@@ -32,6 +32,7 @@ HTTP.Messages.hasheader
 HTTP.Messages.headercontains
 HTTP.Messages.setheader
 HTTP.Messages.appendheader
+HTTP.Messages.removeheader
 HTTP.Messages.decode
 ```
 

src/Handlers.jl

@@ -1,6 +1,6 @@
 module Handlers
 
-export Handler, Middleware, serve, serve!, Router, register!, getparams, getcookies, streamhandler
+export Handler, Middleware, serve, serve!, Router, register!, getparams, getparam, getcookies, streamhandler
 
 using URIs
 using ..Messages, ..Streams, ..IOExtras, ..Servers, ..Sockets, ..Cookies

src/Messages.jl

@@ -53,7 +53,7 @@ export Message, Request, Response,
        reset!, status, method, headers, uri, body, resource,
        iserror, isredirect, retryable, ischunked, issafe, isidempotent,
        header, hasheader, headercontains, setheader, defaultheader!, appendheader,
-       mkheaders, readheaders, headerscomplete,
+       removeheader, mkheaders, readheaders, headerscomplete,
        readchunksize,
        writeheaders, writestartline,
        bodylength, unknown_length,
@@ -413,6 +413,13 @@ function appendheader(m::Message, header::Header)
     return
 end
 
+"""
+    HTTP.removeheader(::Message, key)
+
+Remove header for `key` (case-insensitive).
+"""
+removeheader(m::Message, header::String) = rmkv(m.headers, header, field_name_isequal)
+
 # HTTP payload body
 function payload(m::Message)::Vector{UInt8}
     enc = lowercase(first(split(header(m, "Transfer-Encoding"), ", ")))

src/Pairs.jl

@@ -67,8 +67,8 @@ end
 
 Remove `key` from `collection` of key/value `Pairs`.
 """
-function rmkv(c, k, default=nothing)
-    i = findfirst(x->first(x) == k, c)
+function rmkv(c, k, eq = ==)
+    i = findfirst(x->eq(first(x), k), c)
     if !(i === nothing)
         deleteat!(c, i)
     end

test/handlers.jl

@@ -32,10 +32,10 @@ using HTTP, Test
     @test r(HTTP.Request("GET", "/test/sarv/ghotra/seven")) == 10
     @test r(HTTP.Request("GET", "/test/foo")) == 8
 
-    HTTP.register!(r, "/api/issue/{issue_id}", req -> req.context[:params]["issue_id"])
+    HTTP.register!(r, "/api/issue/{issue_id}", req -> HTTP.getparams(req)["issue_id"])
     @test r(HTTP.Request("GET", "/api/issue/871")) == "871"
 
-    HTTP.register!(r, "/api/widgets/{id}", req -> req.context[:params]["id"])
+    HTTP.register!(r, "/api/widgets/{id}", req -> HTTP.getparam(req, "id"))
     @test r(HTTP.Request("GET", "/api/widgets/11")) == "11"
 
     HTTP.register!(r, "/api/widgets/{name}", req -> (req.context[:params]["name"], req.context[:route]))

test/messages.jl

@@ -55,6 +55,9 @@ using JSON
 
         setheader(req, "X" => "Y")
         @test header(req, "X") == "Y"
+        removeheader(req, "X")
+        @test header(req, "X") == ""
+        setheader(req, "X" => "Y")
     end
 
     @testset "Response" begin