Unintentional(?) breaking change to type of sslconfig

[cmcaine]

HTTP.jl/src/HTTP.jl

Line 27 in b64beb7

const SOCKET_TYPE_TLS = Ref{Any}(OpenSSL.SSLStream)

This is a breaking change because it changes the accepted type for the sslconfig keyword argument that many functions in the public API of HTTP.jl accept.

Did you intend to change this? It seems unrelated to your other changes in b64beb7#r126540636

[cmcaine]

Because other users may now depend on sslconfig accepting an OpenSSL.SSLContext, we could choose the TLS library based on the type of the provided sslconfig (if provided), which seems like an improvement to me.

This is the only function that needs to be modified:

HTTP.jl/src/clientlayers/ConnectionRequest.jl

Line 58 in 8f35185

return function connections(req; proxy=getproxy(req.url.scheme, req.url.host), socket_type::Type=TCPSocket, socket_type_tls::Type=SOCKET_TYPE_TLS[], readtimeout::Int=0, connect_timeout::Int=30, logerrors::Bool=false, logtag=nothing, kw...)

The change of default TLS socket type should still be reverted or documented, imo.