Cleanup connection reuse logic #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #875. The problem in the original issue here was that if you tried to do a websocket request, then very quickly tried another request, the connection pool would try to reuse the same underlying Connection object for the 2nd request, even while the 1st was still in the shutdown and close sequence. This resulted in the 2nd connection having sporadic behavior, usually in the form of an EOFError. The fix here is cleaning up our ConnectionRequest logic around which connections should be reused or closed prior to being released back to the connection pool.
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 80.12% 80.22% +0.09%
==========================================
Files 36 36
Lines 2878 2892 +14
==========================================
+ Hits 2306 2320 +14
Misses 572 572
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875. The problem in the original issue here was that if you tried
to do a websocket request, then very quickly tried another request,
the connection pool would try to reuse the same underlying Connection
object for the 2nd request, even while the 1st was still in the shutdown
and close sequence. This resulted in the 2nd connection having sporadic
behavior, usually in the form of an EOFError.
The fix here is cleaning up our ConnectionRequest logic around which
connections should be reused or closed prior to being released back
to the connection pool.