Retry on TimeoutException, as we did in HTTP v1.9
#1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drvi
force-pushed
the
td-retry-on-timeouts
branch
from
16e8e72
to
ea3bd55
Compare
Drvi
commented
Sep 27, 2023
test/client.jl
Outdated
| try | ||
| HTTP.pushlayer!(test_context_layer) | ||
| # 10.0.0.0 is non-routeable and will result in a connection timeout | ||
| HTTP.get("http://10.0.0.0", connect_timeout=1, retries=3, retry_delays=[0.1, 0.1, 0.1], test_context=test_context) |
There was a problem hiding this comment.
Hmm, this doesn't quite work in CI (edit: seems like macOS CI specifically)
|
I've often seen retried requests succeed after initial timeouts. Including it by default as Making isrecoverable part of the public API and mentioning it in the docs around Request retry arguments would also make sense with or without this change. Could |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1110 we switched
isrecoverable(::Exception)to be opt-in instead of opt-out, and we tried to include the exceptions we historically retried in older versions of HTTP. We didn't includeTimeoutExceptionsin that PR, but given some of the connection timeouts we've encountered in production, I think we want to retry those as well.What do others think?
In the future, ideally, we'd have more granular control over retries to make this a simple runtime switch.