Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename from connection_timeout -> connect_timeout #1131

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

staticfloat
Copy link
Contributor

I think this may be a typo; I'm a little surprised there's not a warning or something that you're using a useless keyword argument.

I think this may be a typo; I'm a little surprised there's not a warning or something that you're using a useless keyword argument.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bdb45c) 82.69% compared to head (37be604) 82.69%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files          32       32           
  Lines        3052     3052           
=======================================
  Hits         2524     2524           
  Misses        528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredrikekre fredrikekre merged commit f9389ae into JuliaWeb:master Nov 28, 2023
10 checks passed
@fredrikekre
Copy link
Member

fredrikekre commented Nov 28, 2023

kwargs... are just forwarded down the chain at all stages I think. Perhaps at the end there should be a check that all kwargs have been picked up by some layer below.

Edit: #1024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants