-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed AWS4AuthRequest Layer | Deprecate HTTP.Post without headers #486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Just noticed a spelling mistake which isn't your fault
Appears to be additional changes to make to appease the tests |
AWS4AuthRequest Layer lived in this package because previously you could not insert your own custom layers into the HTTP stack. With the changes in #443 we can now insert freely into the stack. We no longer need to have AWS code living in this package and it can be removed. The AWS4Auth layer now lives in the AWSCore.jl package. - JuliaCloud/AWSCore.jl@19e20b6t
Forgot that we needed to deprecate |
Before releasing a new breaking version it would be good to consider #469. |
That's a good idea, might as well get in what we can with this release. |
This PR has been noted as desirable before we do a 1.0 release; @mattBrzezinski, any chance you could update it? Even if just the src code and I can help with any test-related changes? |
Yes. I can have this updated probably by the end of the year some time? Just wrapping up other stuff currently. |
The removal of AWSLayer is now included in #789; I'm not familiar with the |
The
AWS4AuthLayer
was introduced into this package because it was required for signing AWS signatures in HTTP. With #443 we are now able to insert custom layers into the HTTP stack, this means we can now move theAWS4AuthLayer
out of this package.I have already moved the
AWS4AuthLayer
intoAWSCore.jl
in this commit. Going forward if you want to use theAWS4Auth
Layer in your stack would be to do something like:As per #473 this CR will also deprecate the usage of
HTTP.Post
without headers for body::Form.