Big update to cookie code #836
Merged
Commits on May 27, 2022
-
Our cookie code was originally ported from the golang stdlib implementation and this represents a (slightly overdue) update from the original source code. The biggest changes are a more solidified cookiejar implementation that is threadsafe and includes all the "getcookies!" and "setcookies!" implementations that we were hand-rolling previously. I also ported over some udpated tests. All in all, this seems like a great improvement IMO, and I'm going to go thru open cookie-related issues and make sure we get everything fixed.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.