Fix access_threaded in the forthcoming interactive threadpool world #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #970. The issue here is that our `access_threaded` function, and thread-specific arrays, all relied on `Threads.nthreads()`, which by default only returns the number of threads in the `:default` threadpool. In the new world where the `:interactive` threadpool exists, there can also be threads there. There is a new function `Threads.maxthreadid()` which helpfully tells us the max id of any thread, regardless of threadpool. So the proposed fix here is that if that function is defined, use that, otherwise fallback to `Threads.nthreads()`.
|
cc: @KristofferC, since, if I remember correctly, he was the original author of this utility? Just as an FYI in case other packages will also need this change in the future (like Parsers.jl). |
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
==========================================
- Coverage 79.99% 79.97% -0.03%
==========================================
Files 36 36
Lines 2959 2961 +2
==========================================
+ Hits 2367 2368 +1
- Misses 592 593 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nickrobinson251
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #970.
The issue here is that our
access_threadedfunction, and thread-specific arrays, all relied onThreads.nthreads(), which by default only returns the number of threads in the:defaultthreadpool. In the new world where the:interactivethreadpool exists, there can also be threads there.There is a new function
Threads.maxthreadid()which helpfully tells us the max id of any thread, regardless of threadpool. So the proposed fix here is that if that function is defined, use that, otherwise fallback toThreads.nthreads().