Skip to content

Commit

Permalink
Address issue with proxy support
Browse files Browse the repository at this point in the history
The `Base.download` function isn't working behind a proxy currently so
we'll use the `BinaryProvider.download` function instead.
  • Loading branch information
omus committed Jun 28, 2019
1 parent e6f8179 commit edab293
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ BinaryProvider = "b99e7846-7c00-51b0-8f62-c81ae34c0232"
Libdl = "8f399da3-3557-5675-b5ff-fb832c97cbdb"

[compat]
BinaryProvider = ">= 0.5.0"
BinaryProvider = "0.5"
julia = "0.7, 1.0"

[extras]
Expand Down
5 changes: 4 additions & 1 deletion deps/build.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ dependencies = [

for dependency in dependencies
file = joinpath(@__DIR__, basename(dependency))
isfile(file) || download(dependency, file)

# Use the BinaryProvider download function as it supports proxies.
# See: https://github.com/JuliaWeb/LibCURL.jl/issues/69
isfile(file) || BinaryProvider.download(dependency, file)

# Build the dependencies
# Note: It is a bit faster to run the build in an anonymous module instead of starting a new
Expand Down

0 comments on commit edab293

Please sign in to comment.