Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : fastify example #2

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

arkerone
Copy link
Contributor

@arkerone arkerone commented Apr 3, 2024

Fix the fastify example :

  • Use the new root option
  • Remove the throw statement and properly start the Fastify server

@Julien-R44
Copy link
Owner

Oops. thanks a lot!

btw, it's still not going to work with the new version. we are missing the import.meta.hot.boundary usage in the import expression. also, we don't need reload anymore too

but I'm currently in the process or reworking the different examples and also the documentation, so no worries, I will handle that

Thanks !

@Julien-R44 Julien-R44 merged commit 18d58d0 into Julien-R44:main Apr 3, 2024
@Julien-R44
Copy link
Owner

Please see the readme for the new version: https://github.com/Julien-R44/hot-hook#boundary and also this PR : #1

sorry for this major change only 24 hours after the initial release 😅

the fastify example has also been updated and works correctly
let me know if you need any help or have any feedback regarding an integration of hot hook in fastify

@arkerone
Copy link
Contributor Author

arkerone commented Apr 3, 2024

Oops. thanks a lot!

btw, it's still not going to work with the new version. we are missing the import.meta.hot.boundary usage in the import expression. also, we don't need reload anymore too

but I'm currently in the process or reworking the different examples and also the documentation, so no worries, I will handle that

Thanks !

Haha no problem, I'm just testing the module! Great work! 😉

@arkerone arkerone deleted the fix/fastify-example branch April 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants