Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fire and forget issues #404

Merged
merged 27 commits into from
Sep 12, 2024
Merged

Conversation

pawlizio
Copy link
Collaborator

No description provided.

@pawlizio pawlizio marked this pull request as draft May 25, 2024 19:50
@pawlizio pawlizio marked this pull request as ready for review September 12, 2024 17:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (0d33673) to head (e7349e6).
Report is 68 commits behind head on master.

Files with missing lines Patch % Lines
pyvlx/connection.py 18.75% 13 Missing ⚠️
pyvlx/pyvlx.py 0.00% 9 Missing ⚠️
pyvlx/node.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   79.00%   78.87%   -0.14%     
==========================================
  Files          78       78              
  Lines        3649     3650       +1     
==========================================
- Hits         2883     2879       -4     
- Misses        766      771       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawlizio
Copy link
Collaborator Author

@Julius2342 Actually my custom_component is already running on pawlizio:fire-forgot-issue branch , it works with no issue so far, any doubts to merge?

https://github.com/pawlizio/my_velux/blob/08eca49ab3d348d6682326a5c9c0bfb1d3cc8071/custom_components/velux/manifest.json#L10

@pawlizio pawlizio merged commit a1e9f33 into Julius2342:master Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants