Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support #85

Closed
loriRyanp opened this issue Feb 5, 2021 · 7 comments
Closed

Language support #85

loriRyanp opened this issue Feb 5, 2021 · 7 comments
Labels
release/8.9.1 patch release

Comments

@loriRyanp
Copy link

loriRyanp commented Feb 5, 2021

Ive updated several document Types locally to turn on the Allow varying by culture. I now need to import in just the settings to a "UAT" db however when I do just import the setting it doesnt appear to be getting updated.

When I choose to update the content and the settings it does.

Is there a way to just update the doctypes Allow varying by culture without affecting the content?

Any help would be brill.

@KevinJump
Copy link
Member

Hi,

We need to look into this, but i have seen similar before (not with uSync) on some versions of v8 - if you change a doctype to vary by culture, Umbraco doesn't necessarily update the content to then put the values into the correct language elements (at least not in the database) we have code in the core uSync to cater for this on import, because the default values actually remain with no culture even though the content should have cultured values

i think maybe we might need to apply a similar fix on export so non-cultured values are infact copied to a default culture (if that is missing) - but this behavior can be a little odd. we might say, changing to vary by culture requires a content sync

@KevinJump
Copy link
Member

Hi -

I've been looking at this today - at the moment i can't quite recreate the issue.

so i have done the following:

  1. got two sites in sync without varying by culture
  2. updated a doctype to vary by culture
  3. also updated some properties on that doctype to vary by culture
  4. published just the settings to the other site*.

when i do this and look on the target site the content is in the default (en-us) language as expected ?

this was on latest Umbraco/uSync - more than willing to try on another version -

  • What version of umbraco & uSync are you on ?
  • Is this the same process you did - or is there missing/extra steps?

*noticed there is an issue syncing languages on uSync.Complete 8.9 - but this doesn't effect the default language stuff.

@loriRyanp
Copy link
Author

loriRyanp commented Feb 9, 2021 via email

@KevinJump
Copy link
Member

OK, I will have a look on v8.6.4 of umbraco. that sounds very similar to what i just tried on a fresh install (Umbraco v8.11.1) - but i will double check and install v v8.6.4 site and see if i can see any diffrences.

@KevinJump
Copy link
Member

Some results of testing:

v8.11.1
variants-Eight11One

v8.6.4: (same thing)
variants-eightsixfour

Just to confirm is this what you are expecting to happen ? (indeed does this happen when you do it? there might be another issue somewhere 😞 )

or do you want the content in all variants ? - (in these examples it goes into the default language)

@loriRyanp
Copy link
Author

loriRyanp commented Feb 9, 2021 via email

@KevinJump KevinJump added the release/8.9.1 patch release label Feb 17, 2021
@KevinJump
Copy link
Member

Hi,

this is fixed in 8.9.1 (Just released)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/8.9.1 patch release
Projects
None yet
Development

No branches or pull requests

2 participants