Fix subfolder && add subfolder tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunnYu
reviewed
Dec 20, 2023
| @@ -159,7 +159,7 @@ def from_pretrained(cls, pretrained_model_name_or_path: str, *model_args, **kwar | |||
| config = AutoConfig.from_pretrained("bert-base-uncased") | |||
| config.save_pretrained('./bert-base-uncased') | |||
| """ | |||
| subfolder = kwargs.pop("subfolder", "") | |||
There was a problem hiding this comment.
这样会导致后续一些子函数中无法获取到kwargs中的subfolder，导致找不到正确的配置路径
JunnYu
reviewed
Dec 20, 2023
| @@ -1559,7 +1559,9 @@ def from_pretrained(cls, pretrained_model_name_or_path, *args, **kwargs): | |||
| for k, v in resolved_vocab_files.items(): | |||
| if v is not None and os.path.isfile(v): | |||
| tokenizer_config_file_dir_list.add(os.path.dirname(v)) | |||
| assert len(tokenizer_config_file_dir_list) == 1, "All tokenizer files should be in the same directory." | |||
| tokenizer_config_file_dir_list = list(tokenizer_config_file_dir_list) | |||
| # TODO: check this | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
单测时需要设置aistudio的token，