-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Debugger - graphical breakpoints broken when docstring preceeds module #271
Comments
Interesting. It works if you do this: julia> includet("/tmp/dsmod2.jl")
julia> breakpoint(docstringtest.foo)
1-element Array{JuliaInterpreter.BreakpointRef,1}:
breakpoint(foo() in Main.docstringtest at /tmp/dsmod2.jl:6, line 6)
julia> using JuliaInterpreter
julia> @interpret docstringtest.foo()
(Frame for foo() in Main.docstringtest at /tmp/dsmod2.jl:6
b 1 6 1 ─ %1 = (+)(4, 5)
2 6 │ x = %1
3 6 └── return %1, breakpoint(foo() in Main.docstringtest at /tmp/dsmod2.jl:6, line 6)) The fact that it paused (plust that julia> Juno.@run docstringtest.foo()
9 (without breaking), and indeed I see an error if I try to set the breakpoint graphically. |
I can repro this with the latest JuliaInterpreter release (and also with master for JuliaInterpreter, Revise, and CodeTracking):
|
Since we create modules incrementally as we advance through `split_expressions!`, when we extract docstrings we need to avoid duplicating the module definition itself. Fixes JunoLab/Juno.jl#271
Thanks for finding the MWE, @pfitzseb! And for the report, @BioTurboNick. |
Since we create modules incrementally as we advance through `split_expressions!`, when we extract docstrings we need to avoid duplicating the module definition itself. Fixes JunoLab/Juno.jl#271
This can now be closed. |
Thanks for the quick fix! Can confirm this case works fine now. |
Please search existing issues to avoid duplicates.
Details
Breakpoints fail to set in this code:
But work in this code (after reloading with includet()):
The text was updated successfully, but these errors were encountered: