change cache to work with figures #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLD2. JLD2 fails to save strings longer than 2^16 characters, which can occur in the stringmime() of large figures.
Updated REQUIRE & Project.toml to include Serialization instead of FileIO and JLD2
1 similar comment
|
Thanks! Sorry for the long delay in my response, I think this is a useful change and it seems good to have less dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JLD2 cannot save strings longer than 2^16 characters. Weave runs into this problem when trying to cache figures. I changed read_cache & write_cache to use Serialization instead of JLD2. I understand there's some downsides to this regarding forward & backward compatibility, so I understand if you don't want to merge it.
I also added a test for caching with figures and updated the expected output for two of the errors_tests.