Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre #338 #341

Merged
merged 6 commits into from
May 23, 2020
Merged

pre #338 #341

merged 6 commits into from
May 23, 2020

Conversation

aviatesk
Copy link
Member

This PR serves as a pre-refactor for #338

Main reasons

  • separate formatting logic from chunk executions, which will enable more unit testing on rendering logic
  • fix terminologies
  • general refactors

@aviatesk
rm unused stuff
f71a491
@aviatesk
separate format logic from WeaveDoc:
3c76b80 
- this is just a first step, though
@aviatesk
consistent and clearer terminology:
29ff436 
- formatted -> body/rendered
- wdate -> weave_date
- wsource (or source) -> weave_source
- wdate -> weave_date
@aviatesk aviatesk merged commit 60fc450 into master May 23, 2020
@aviatesk aviatesk deleted the avi/preprefactor branch May 23, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aviatesk