-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export formats as wrapper #380
Conversation
@JonasIsensee thanks for your PR again, and this certainly looks so great, thanks for your suggestion ! I will make sure I will review on this until weekend. |
src/rendering/htmlformats.jl
Outdated
@@ -157,4 +143,4 @@ function set_format_options!(docformat::Pandoc2HTML; template = nothing, css = n | |||
docformat.pandoc_options = pandoc_options | |||
end | |||
|
|||
render_figures(docformat::Pandoc2HTML, chunk) = render_figures(Pandoc(), chunk) | |||
#render_figures(docformat::Pandoc2HTML, chunk) = render_figures(Pandoc(), chunk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this commented out ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question. I have no idea. That must have happened by accident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, then let's keep the previous behavior for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonasIsensee super sorry for being late to have a review... Code looks awesome, left few comments, but I would like to merge this anyway after waiting a bit for you.
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
- Coverage 74.47% 73.79% -0.69%
==========================================
Files 25 26 +1
Lines 1332 1347 +15
==========================================
+ Hits 992 994 +2
- Misses 340 353 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Shuhei Kadowaki <[email protected]>
@JonasIsensee well, are you still interested in this project ? I would like to give you an write access for this repository if you want :) |
Thank you for your trust! I did familiarize myself with a significant part of the code base for the last few PRs so I'd be happy to help with discussion and review. What I'm trying to say: I'll happily accept write access but in the immediate future I will not use it to actively develop. |
Similar to #379 except it is now based on the new
master
branch.A net reduction in lines of code while adding functionality. ;)
This PR also fixes an issue in the latex formats where unicode was not escaped in output chunks.
(Something similar should be done for
Pandoc
since it reports