Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export formats as wrapper #380

Merged
merged 8 commits into from
Oct 3, 2020
Merged

Conversation

JonasIsensee
Copy link
Contributor

@JonasIsensee JonasIsensee commented Jun 15, 2020

Similar to #379 except it is now based on the new master branch.

A net reduction in lines of code while adding functionality. ;)

This PR also fixes an issue in the latex formats where unicode was not escaped in output chunks.
(Something similar should be done for Pandoc since it reports

julia> weave("FIR_design.jmd"; doctype="pandoc2pdf", cache=:refresh, keep_unicode=false)
[WARNING] Missing character: There is no π (U+03C0) in font [lmmono12-regular]:!
[WARNING] Missing character: There is no ⋮ (U+22EE) in font [lmmono12-regular]:!
[WARNING] Missing character: There is no ⋮ (U+22EE) in font [lmmono12-regular]:!
[ Info: Weaved to /home/jonas/.julia/dev/Weave/examples/FIR_design.pdf
"/home/jonas/.julia/dev/Weave/examples/FIR_design.pdf"

@aviatesk
Copy link
Member

@JonasIsensee thanks for your PR again, and this certainly looks so great, thanks for your suggestion ! I will make sure I will review on this until weekend.

@@ -157,4 +143,4 @@ function set_format_options!(docformat::Pandoc2HTML; template = nothing, css = n
docformat.pandoc_options = pandoc_options
end

render_figures(docformat::Pandoc2HTML, chunk) = render_figures(Pandoc(), chunk)
#render_figures(docformat::Pandoc2HTML, chunk) = render_figures(Pandoc(), chunk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented out ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good question. I have no idea. That must have happened by accident

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, then let's keep the previous behavior for now

Copy link
Member

@aviatesk aviatesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonasIsensee super sorry for being late to have a review... Code looks awesome, left few comments, but I would like to merge this anyway after waiting a bit for you.

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #380 into master will decrease coverage by 0.68%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   74.47%   73.79%   -0.69%     
==========================================
  Files          25       26       +1     
  Lines        1332     1347      +15     
==========================================
+ Hits          992      994       +2     
- Misses        340      353      +13     
Flag Coverage Δ
#unittests 73.79% <12.50%> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rendering/htmlformats.jl 84.48% <ø> (+1.43%) ⬆️
src/rendering/pandocformats.jl 85.18% <ø> (ø)
src/rendering/rendering.jl 87.50% <ø> (ø)
src/writer/latex.jl 0.00% <0.00%> (ø)
src/rendering/texformats.jl 84.90% <11.11%> (-1.64%) ⬇️
src/rendering/exportformat.jl 14.28% <14.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 196d4ca...e02d5ce. Read the comment docs.

@aviatesk aviatesk merged commit c9fc740 into JunoLab:master Oct 3, 2020
@aviatesk
Copy link
Member

aviatesk commented Oct 3, 2020

@JonasIsensee well, are you still interested in this project ? I would like to give you an write access for this repository if you want :)

@JonasIsensee
Copy link
Contributor Author

@aviatesk

Thank you for your trust!
My work and thus the tools I need have changed a little since June and so - right now - I can't use Weave anymore.
(But that could just as well change again in a few months)

I did familiarize myself with a significant part of the code base for the last few PRs so I'd be happy to help with discussion and review.

What I'm trying to say: I'll happily accept write access but in the immediate future I will not use it to actively develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants