Fix for out_path only working for directories #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now see that the Julia formatter has changed all the formatting in the Weave.jl file, but I am not sure how to fix that... I'll look into it later if that is a problem. |
|
Can you please remove the changes made by formatter ? I'd like to keep the style consistent with the other parts of code base (especially whitespaces around kwargs) |
|
Sure thing, formatting should now be correct. |
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now out_path creates the right file, see #383. All tests but 3 pass, but those were not working before on my system. All behavior should thus be the same.