-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: strip trailing dots #651
Conversation
56c18a3
to
2edaf2b
Compare
@pfitzseb can you make a quick review on this ? This PR extends our These lines were adapted from So the now the behavior of
As a result, we can extract |
Sorry, I was kinda out of commission for the last couple of days. Tbh, I don't like the
API. Do you anticipate any need for user defined regexps there?
for |
No worries :)
yeah, fair enough. I made such a complex API since I thought it would be more extensible, but I'm not coming up with the use cases of the user-defined regexes other than this case for now, to be honest.
And so this would be better solution -- stripping trailing dots would be fairly easy with this approach, too. I will try to change the function APIs then :) |
2edaf2b
to
601f90c
Compare
okay, e9e9845 hopefully simplifies the logic. |
e9e9845
to
a4626be
Compare
a4626be
to
d4358c0
Compare
No description provided.