Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recover OS notification #736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

recover OS notification #736

wants to merge 1 commit into from

Conversation

aviatesk
Copy link
Member

OS notifications is still an issue ?
Searching in atom repo, there seems to be a problem in tree-view stuff in electron<4 on macOS, but couldn't find an issue related to OS notification.

@pfitzseb
Copy link
Member

electron/electron#18701 is the upstream issue -- seems like it's only been fixed very recently and I don't think the new Electron version has propagated to Atom yet.

@aviatesk
Copy link
Member Author

okay.
Well, do you think we can disable close only on macOS ?
I found notifications are swept away after few seconds anyway, so I guess we actually don't need close calls from the beginning, no ?

I started to use Juno for tasks including time consuming computation, and I found I really want this OS notification.

(P.S. I also really can't reproduce the crash on my macOS Mojave 10.14.6 even when calling closes...)

@pfitzseb
Copy link
Member

It's probably fine to re-enable this fi we can test it on all platforms and keep it behind a setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants