Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert JSON serialization to how it was with Newtonsoft #3302

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Revert JSON serialization to how it was with Newtonsoft #3302

merged 1 commit into from
Oct 5, 2024

Conversation

Abrynos
Copy link
Member

@Abrynos Abrynos commented Oct 5, 2024

Checklist

  • I read and understood the Contributing Guidelines.
  • This is not a duplicate of an existing merge request.
  • I believe this falls into the scope of the project and should be part of the built-in functionality.
  • My code follows the code style of this project.
  • I have added tests to cover my changes, wherever they are necessary.
  • All new and existing tests pass.

Changes

Closes #3301

New functionality

None

Changed functionality

Reverts JSON serialization to how it was with Newtonsoft.Json by not escaping unicode characters.

Removed functionality

None

Additional info

Thank you in advance for considering the inclusion of this merge request!

@JustArchi JustArchi added the ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. label Oct 5, 2024
@JustArchi JustArchi merged commit de9900a into JustArchiNET:main Oct 5, 2024
20 checks passed
@Abrynos Abrynos deleted the revert-json branch October 5, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some characters are now saved as escape sequences on BotName.json file
2 participants
@Abrynos @JustArchi