Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in highlighting involving commas #122

Closed
sheaf opened this issue Apr 26, 2020 · 3 comments
Closed

Regression in highlighting involving commas #122

sheaf opened this issue Apr 26, 2020 · 3 comments

Comments

@sheaf
Copy link
Collaborator

sheaf commented Apr 26, 2020

3.0.0 has introduced the following regression in highlighting:

comma_highlighting

The comma after True removes its highlighting. This might be related to #121 which is also caused by commas.

@sheaf
Copy link
Collaborator Author

sheaf commented Apr 27, 2020

This isn't limited to commas:

bracket_highlighting
Here A1 is not highlighted because of the comma, and B1 because of the parenthesis. Same issue also happens with lists:
bracket_highlighting_2

@sheaf
Copy link
Collaborator Author

sheaf commented Apr 27, 2020

Unfortunately the fix seems to have broken qualified names:

before:
qualified_before

after:
qualified_after

edit: and it also broke promotion ticks:

before:
ticks_before

after:
ticks_after

@sheaf
Copy link
Collaborator Author

sheaf commented May 1, 2020

All these regressions have now been taken care of, and are covered by the tests to ensure no further regressions are possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant