-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing keywords: data and type families, pattern synonyms, deriving via #72
Comments
See #72 We still need support for multi-line deriving via
Excellent, the addition of highlighting for type families and pattern synonyms is very much appreciated. Thanks! The code for highlighting type families should be extended to work with data families too: For pattern synonyms, multiple patterns are not currently highlighted properly: As seen in this screenshot, it would also be nice to support the keywords for the three built-in deriving strategies: Finally, the highlighting for the single-line deriving via that is currently implemented seems to always require parentheses: Sorry for including all this in this single ticket; I can split it out into other issues if you would prefer. |
I realise now that defining multiple patterns at once in a pattern synonym is actually already supported, but it's #122 that makes it look otherwise. |
Okay, I think I got them all now? Thanks for the diligent reporting! |
All the keywords mentioned in this ticket are now supported, so I'm closing this issue. Some highlighting issues still remain, e.g. type families aren't correctly highlighting types (highlighting them as values instead). This is being tracked separately in #133. |
Here are some examples of missing keywords:
the keywords "family", "instance" and "where" in type/data families, e.g.:
"via" from the deriving via extension:
(Note also that the type variable in the standalone deriving declaration is not highlighted correctly.)
"pattern" for a pattern synonym declaration
The text was updated successfully, but these errors were encountered: