Improve custom quasi-quotation parsing #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: currently parsing `[int||Text|]` fails with the current Haskell grammar. This happens, because we parse the beginning in a greedy way, and so parse `[int||` as beginning of typed quasi-quoter. Thus end must be `||]` respectively, but we never meet it. Solution: custom quoters are never typed, and GHC (tried with 8.10.7 version) interprets `[int||Abc||]` as a mere quoter with `|Abc|` body. So here we adjust the pattern for custom quoters to be never typed.
|
Thank you very much for taking the time to make an MR. I didn't realise that custom quasi-quoters never used the typed syntax. |
Yeah, took me a while to come to what is the GHC's rule here. Thanks for the quick response! |
|
Thank you. Yeah @sheaf is for sure the active maintainer here 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: currently parsing
[int||Text|]fails with the current Haskellgrammar.
This happens, because we parse the beginning in a greedy way, and so
parse
[int||as beginning of typed quasi-quoter. Thus end must be||]respectively, but we never meet it.Solution: custom quoters are never typed, and GHC (tried with 8.10.7
version) interprets
[int||Abc||]as a mere quoter with|Abc|body.So here we adjust the pattern for custom quoters to be never typed.
Resolves #203.