Update syntax for numeric literals #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an exact pattern match version. * Modify syntax for HexFloatLiterals extension [1] * Modify syntax for BinaryLiterals extension [2] * Modify syntax for NumericUnderscores extension [3] [4] I visually verified this patch with the these files [5] [6]. [1]: https://ghc.haskell.org/trac/ghc/ticket/9224 [2]: https://ghc.haskell.org/trac/ghc/ticket/13126 [3]: https://ghc.haskell.org/trac/ghc/ticket/14473 [4]: https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0009-numeric-underscores.rst [5]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsuite/tests/parser/should_run/NumericUnderscores0.hs [6]: https://github.com/takenobu-hs/ghc/blob/squashed-numeric-underscores/testsuite/tests/parser/should_run/NumericUnderscores1.hs
|
Thank you. I think we should use the correct version so long as there are no complaints about the speed. |
|
I appreciate for your quick response. |
|
No problem. I'll release this change soon. Stay tuned 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please update this for syntax highlighting of numeric literals?
This patch implemented Haskell/GHC's newly accepted proposal for numeric literals. (I'm author of the proposal.)
I visually verified this patch with a test file.
If you need more speed than accuracy, I will send the following fast (but approximate) pattern match version instead.
Regards,
Takenobu