Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Codecov coverage reporting by configuring path fixes (which are needed because Codecov doesn't natively understand Kotlin source organization).
The path fix re-writes the path at which Codecov will look for source files, whereas when looking for class
com.juul.kronicle.Example
Codecov would traditionally look for that class file incom/juul/kronicle
(as that is convention for Java). Since Kotlin can have a flatter source code organization (whereas the empty initial package directories can be omitted), we have to instruct Codecov accordingly.Codecov path fixes are structured as
<files in coverage report>::<corresponding paths in project>
; the fix added in this PR (com/juul/khronicle::
) doesn't have a path on the right side of the::
, meaning that we are basically dropping the package directories that Kotlin doesn't require. For example, if we had a class in packagecom.juul.khronicle.example
then the path fix would cause Codecov to look for the source file inexample/
.