Fix blob doesn't get rendered if todo is in last line of a file

Juulsn · Mar 26, 2022 · e143abd · e143abd
1 parent d5da82d
commit e143abd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 15 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/src/TodoDetails.ts b/src/TodoDetails.ts
@@ -21,17 +21,13 @@ function getFileBoundaries(changes: any[], line: number, paddingTop = 0, padding
 
   let start;
   if(line == firstChangedLine){
-    start = Math.max(0, line - paddingTop);
+    start = Math.max(1, line - paddingTop);
   } else {
     start = Math.max(line - paddingTop, firstChangedLine)
   }
 
-  let end;
-  if(line == lastChangedLine) {
-    end = line + paddingBottom;
-  } else {
-    end = Math.min(line + paddingBottom, lastChangedLine)
-  }
+  // we dont know the actual lines count of the file, so we cant add something like minPadding (at least for the bottom)
+  let end = Math.min(line + paddingBottom, lastChangedLine)
 
   return {start, end}
 }