Merge Develop into Master post Meeetup talk #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding functions/methods to prevent the bot from sending PM's. Currently working for InMemoryStorage
Added PM Preferences methods to AzureStorage(storage) class
Added methods to RedisStorage to make use of the PM Preference setting. (left commented out)
switched to dev branch, back to InMemoryStorage only
Removed debugging lines, got rid of/commented out unused code
Remove spaces. PM Preference options are now in Azure, Redis, and InMemoryStorage. Testing is needed for Azure, and Redis
if/elif/else clause to handle user's pm preference options when the bot needs to send a message
Something goofy happened previously. PM Preference options are coded out for Azure and Redis storage options now. Testing still needed.
Checking for length of self.parts to decide if it should act as a toggle. Instead of a try/except for an IndexError
Testing the possibility of having the bot reply to user's request for a leaderboard/fullboard. Bots do not appear to be capable of posting code snippets. So this is an alternative way of 'collapsing' the leaderboard
Allow the bot to reply to a user's request for a leaderboard/fullboard since bots are not capable of posting/attaching code snippets
fixed it!
Ability to silence DM messages from HeyFireball #14
…s. Fixed index error.
Parts index error
Updated InMemory storage with Total and Daily ability.
Collapsible leaderboard
Fixed bug around target_id_only not getting set.
There was the potential for an inconsistency in the event that a user passed any argument other than on/off. It would cause things like having the bot pm the user the setpm off message because PM's were actually on for the user. This patch prevents that issue by giving a third possible return value of 2. If '2' is returned, the bot will make no changes, inform the user that it can't understand the argument, and show the user the arguments that are accepted for the setpm command. The _extract_setting method has also been updated to stop hardcoding indexes, matching the above _extract_** methods
…del and fixed some documentation.
|
Please review Pull Request #28 before merging develop into master. There is some wonky behavior that can arise with the setpm command in its current state |
Simplification & bug-fix of _extract_setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to get these changes into the production version at work, and to get all the work Jay did in there.