-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cxx qt lib extras #860
Conversation
It"s WIP. |
ok pb: => we need assertion_utils.h + qstring.h so what's missing for cxx-qt-lib in extra ? |
ok removing cxx-qt-lib directly |
I hope that it uses qstring.h from cxx-qt-lib and not qt directly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is missing for merging it ? :) |
I think there was only ...
So maybe we are ready? |
Yep we decided to wait after 0.7 for splitting in another repo. |
0e608ae
to
c783f3e
Compare
Meanwhile what is happening to CI, seen Windows and macOS fail once with this in the
|
I'm getting random 500 errors navigating the github website, so suspect it is related. And there is a github incident https://www.githubstatus.com/incidents/5ly0psff2s5d |
… by CxxQtBuilder directly
ce20cc8
to
21723b2
Compare
21723b2
to
27720eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.