-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to specify objdump + perf on command line #556
Comments
Better idea: provide an option to select to configuration via command line. That would take care of all the other stuff (sysroot, ...) too |
And how would you provide the configuration? |
@milianw Would you accept a PR that adds |
ping @milianw about that question and ping @lievenhey about the specs for the configuration option. |
I'm fine with adding these cli args, but please call them |
This commit removes a lot of unnecessary data pass around. We have all that data in the Settings struct so lets use it. closes: #556
This commit removes a lot of unnecessary data pass around. We have all that data in the Settings struct so lets use it. closes: #556
Is your feature request related to a problem? Please describe.
Different recordings need different objdump binaries. To provide that Hotspot already provides a setting for both this and perf.
It would be nice to be able to specify that on the command line, too; as is the case for other options.
Describe the solution you'd like
command line options for those, possibly
--perf
and--objdump
; this would also allow to create local aliases that call hotspot with the right settings for seldom uses, removing the need to set, then later unsetDescribe alternatives you've considered
Set them in the configuration, then unset when not needed anymore.
Additional context
I you want me to, I could try creating a PR, but I don't see how, if at all, I could add a reasonable automated test for that.
The text was updated successfully, but these errors were encountered: