Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to specify objdump + perf on command line #556

Closed
GitMensch opened this issue Nov 12, 2023 · 5 comments · Fixed by #653 · May be fixed by #674
Closed

allow to specify objdump + perf on command line #556

GitMensch opened this issue Nov 12, 2023 · 5 comments · Fixed by #653 · May be fixed by #674

Comments

@GitMensch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Different recordings need different objdump binaries. To provide that Hotspot already provides a setting for both this and perf.
It would be nice to be able to specify that on the command line, too; as is the case for other options.

Describe the solution you'd like
command line options for those, possibly --perf and --objdump; this would also allow to create local aliases that call hotspot with the right settings for seldom uses, removing the need to set, then later unset

Describe alternatives you've considered
Set them in the configuration, then unset when not needed anymore.

Additional context
I you want me to, I could try creating a PR, but I don't see how, if at all, I could add a reasonable automated test for that.

@lievenhey
Copy link
Contributor

Better idea: provide an option to select to configuration via command line. That would take care of all the other stuff (sysroot, ...) too

@GitMensch
Copy link
Contributor Author

And how would you provide the configuration?
The idea of adding the two missing configuration options is to be able to "manually" provide those configurations via aliases.

@GitMensch
Copy link
Contributor Author

GitMensch commented Nov 26, 2023

@milianw Would you accept a PR that adds --perf / --objdump?

@GitMensch
Copy link
Contributor Author

GitMensch commented Apr 15, 2024

Would you accept a PR that adds --perf / --objdump?

ping @milianw about that question and ping @lievenhey about the specs for the configuration option.

@milianw
Copy link
Member

milianw commented Apr 16, 2024

I'm fine with adding these cli args, but please call them --perf-binary and --objdump-binary

lievenhey added a commit that referenced this issue May 29, 2024
This commit removes a lot of unnecessary data pass around. We have all
that data in the Settings struct so lets use it.

closes: #556
lievenhey added a commit that referenced this issue Jun 4, 2024
This commit removes a lot of unnecessary data pass around. We have all
that data in the Settings struct so lets use it.

closes: #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants