fix: Fix JSON output from ctest not being received

'exit' spawn event does not wait for stdout to be closed. 'close' is the correct event Also fixes the tests being flaky
KDAB · Jun 5, 2024 · 9cea2c3 · 9cea2c3
1 parent 45a2eac
commit 9cea2c3
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -5,3 +5,4 @@
 *.tgz
 *.log
 /out/
+/src/*.js
diff --git a/out/cmake.js b/out/cmake.js
@@ -49,9 +49,16 @@ class CMakeTests {
                 child.stdout.on("data", (chunk) => {
                     output += chunk.toString();
                 });
-                child.on("exit", (code) => {
+                child.on("close", (code) => {
                     if (code === 0) {
-                        resolve(this.ctestJsonToList(output));
+                        if (output.length == 0) {
+                            console.error("ctestJsonToList: Empty json output. Command was ctest --show-only=json-v1 , in " +
+                                this.buildDirPath);
+                            reject(new Error("Failed to get ctest JSON output"));
+                        }
+                        else {
+                            resolve(this.ctestJsonToList(output));
+                        }
                     }
                     else {
                         reject(new Error("Failed to run ctest"));

diff --git a/src/cmake.ts b/src/cmake.ts
@@ -44,9 +44,17 @@ export class CMakeTests {
         output += chunk.toString();
       });
 
-      child.on("exit", (code) => {
+      child.on("close", (code) => {
         if (code === 0) {
-          resolve(this.ctestJsonToList(output));
+          if (output.length == 0) {
+            console.error(
+              "ctestJsonToList: Empty json output. Command was ctest --show-only=json-v1 , in " +
+                this.buildDirPath,
+            );
+            reject(new Error("Failed to get ctest JSON output"));
+          } else {
+            resolve(this.ctestJsonToList(output));
+          }
         } else {
           reject(new Error("Failed to run ctest"));
         }