Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change custom extend to be in line with EDR 1.1 spec #9

Merged
merged 1 commit into from
May 17, 2024

Conversation

lukas-phaf
Copy link
Collaborator

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.96%. Comparing base (5661440) to head (3a74b86).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   97.95%   97.96%   +0.01%     
==========================================
  Files          10       10              
  Lines         196      197       +1     
==========================================
+ Hits          192      193       +1     
  Misses          4        4              
Flag Coverage Δ
unittests 97.96% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ernstdevreede ernstdevreede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lukas-phaf lukas-phaf merged commit efa28a7 into main May 17, 2024
7 checks passed
@lukas-phaf lukas-phaf deleted the issue-8-custom-extent branch May 17, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom extent class type has incorrect interval field type
3 participants