Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: automatic change of eigen to include #32

Merged
merged 2 commits into from
May 28, 2024

Conversation

KOKIAOKI
Copy link
Owner

@KOKIAOKI KOKIAOKI commented May 28, 2024

Current CMake failed to select eigen version automatically when thirdparty/eigen is cloned.
I fixed the conditional branch of USE_THIRDPARTY_EIGEN.

Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

The changes in the CMakeLists.txt file involve toggling the USE_THIRDPARTY_EIGEN flag based on whether the Eigen libraries are found. If Eigen is detected, the flag is set to ON and the relevant include directories are configured; otherwise, it is set to OFF. Additionally, messages are added to indicate which include directories are selected based on Eigen's presence.

Changes

File Change Summary
CMakeLists.txt Toggled USE_THIRDPARTY_EIGEN flag based on Eigen detection; added messages for include directories.

In the realm of code so grand,
Eigen's presence takes a stand.
Flags will toggle, paths will show,
Directories where data flow.
With messages clear and bright,
Building code is pure delight. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to full the review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
CMakeLists.txt (1)

33-33: Clear and informative message outputs based on the Eigen configuration.

Consider specifying the actual path in the status messages for greater clarity, e.g., message(STATUS "Using third-party Eigen at ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/Eigen").

Also applies to: 36-36

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bb917cf and 7e5f86e.
Files selected for processing (1)
  • CMakeLists.txt (2 hunks)
Additional comments not posted (2)
CMakeLists.txt (2)

9-11: Correct handling of the USE_THIRDPARTY_EIGEN flag when Eigen is not found.


12-12: Proper setting of the USE_THIRDPARTY_EIGEN flag when Eigen is found.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 7e5f86e and 50c2d2b.
Files selected for processing (1)
  • CMakeLists.txt (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CMakeLists.txt

@KOKIAOKI KOKIAOKI merged commit 91c6d4d into main May 28, 2024
@KOKIAOKI KOKIAOKI deleted the feature/fix_thirdparty_eigen branch June 1, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant