Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit OrderFailure #375

Open
vapaj opened this issue May 15, 2020 · 1 comment
Open

Audit OrderFailure #375

vapaj opened this issue May 15, 2020 · 1 comment
Assignees
@vapaj
Labels
vetrina

Comments

@vapaj
Copy link
Member

vapaj commented May 15, 2020

See that OrderFailure type makes sense and audit/fix places where it's being used. For instance, we are wildly using UnexpectedError in situations where probably better constructors exists.
@vapaj vapaj added the vetrina label May 15, 2020
@vapaj vapaj self-assigned this May 15, 2020
@ae-mo
Copy link
Contributor

ae-mo commented May 15, 2020

Also I was thinking is OrderFailure an appropriate name anymore? Cause in #373 I have added InitializationError constructor to it, which represents an error that takes place before any order is created.

@vapaj vapaj mentioned this issue May 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vapaj vapaj

Labels
vetrina
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ae-mo @vapaj