Add external JSX rendering to Vetrina component #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapaj
reviewed
May 14, 2020
vapaj
reviewed
May 14, 2020
* Add InitializationError constructor to OrderFailure * Remove UnexpectedServerError from PurchaseState * Change prop unexpectedError type to JSX * Render external view on InitializationError, UnexpectedError, ServerError
ae-mo
force-pushed
the
fix/vetrina-server-error
branch
from
e215514
to
01acc2d
Compare
vapaj
reviewed
May 15, 2020
|
Would you also add a note of this prop to the README and bump the vetrina version, as this PR adds behavioural changes? 🙏 |
* Render vetrina error view on ServerError, UnexpectedError
vapaj
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #352.