Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on Relationships #1494

Closed
linuxgurugamer opened this issue Oct 15, 2015 · 5 comments · Fixed by #3041
Closed

Search on Relationships #1494

linuxgurugamer opened this issue Oct 15, 2015 · 5 comments · Fixed by #3041
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI

Comments

@linuxgurugamer
Copy link
Contributor

Since the netkan/ckan spec has comments, why not add the comments to the Metadata window, and allow searching inside the comments. For example, PlanetPacks

@mheguy
Copy link
Contributor

mheguy commented Oct 15, 2015

Comments are generally used internally within the metadata team to indicate things like who to ask questions to about a specific mod, or changes that can be made at specific milestones to metadata. It is not an inclusive tagging system where mods have comments that specify their category. I think what you want is more along the lines of #1021.

Some non-categorical examples of comments which would only serve to confuse some users:

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/AdvancedJetEngine.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/BahamutoDynamicsPartsPack.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/BurnTogether.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/CactEye2.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/Canadarm.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/CustomAsteroids-Pops-Stock-Inner.netkan

👎 from me. We shouldn't be surfacing internal comments to end users and we shouldn't try to co-opt comments to server a purpose other than their intended one.

@linuxgurugamer
Copy link
Contributor Author

Got it.

I got started on this when i saw the message about putting "PlanetPack"
into a comment.

After reading your reply (which makes total sense), how about changing
this from a comment search, to a relationship search; for example, if I
want to see all the available planetpacks, I could search on
"Kopernicus" in the "Depends" relationship. Right now, I have to
download the CKAN repo and grep for that. Doable, but not everyone
knows or wants to know/install Linux/unix based commands.

JBB

On 10/14/2015 11:03 PM, Matthew wrote:

Comments are generally used internally within the metadata team to
indicate things like who to ask questions to about a specific mod, or
changes that can be made at specific milestones to metadata. It is not
an inclusive tagging system where mods have comments that specify
their category. I think what you want is more along the lines of #1021
#1021.

Some non-categorical examples of comments which would only serve to
confuse some users:

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/AdvancedJetEngine.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/BahamutoDynamicsPartsPack.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/BurnTogether.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/CactEye2.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/Canadarm.netkan

https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/CustomAsteroids-Pops-Stock-Inner.netkan

👎 from me. We shouldn't be surfacing internal comments to end users
and we shouldn't try to co-opt comments to server a purpose other than
their intended one.


Reply to this email directly or view it on GitHub
#1494 (comment).

@politas politas changed the title Feature request: Search on comments Feature request: Search on Relationships Apr 23, 2016
@ayan4m1 ayan4m1 added Enhancement New features or functionality GUI Issues affecting the interactive GUI labels Aug 3, 2016
@ayan4m1
Copy link
Contributor

ayan4m1 commented Aug 3, 2016

Would "reverse dependency" lookup in the Relationships tab support your use cases? That way we wouldn't have to spec out as much related to filter/search changes, just a new element in the dropdown on the Relationships tab.

@ayan4m1 ayan4m1 changed the title Feature request: Search on Relationships Search on Relationships Aug 3, 2016
@politas
Copy link
Member

politas commented Aug 3, 2016

It would certainly be useful for one-way conflicts relationships.

@HebaruSan
Copy link
Member

#2736 would be a good time to add more searches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants