Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider supports in recommendations screen descriptions #3028

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Apr 4, 2020

Background

In #2960 we added a "Supported By" section to the GUI recommendations screen. Unlike the recommendation and suggestion sections, which show mods mentioned by the mods chosen for install, this section is based on relationships in which other mods mention the chosen mods. This provides better support for certain scenarios:

  • If I install a tech tree, I would be able to see which mods integrate with that tech tree
  • If I install RPM, I would be able to see mods that provide MFD pages
  • If I install TweakScale, I would be able to see part mods that allow scaling

Problem

The orange marks highlight places in the current UI that incorrectly state or imply that "supported by" mods are recommended or suggested by the chosen mods (because that was how the screen worked after #2744 and the text was not updated):

image

Only the blue highlighted part indicates the status of those mods, and it's pretty terse.

The German translation also has this problem.

Changes

Now the English UI no longer says that supported-by modules are recommended or suggested by the chosen mods:

  • The tab caption now mentions supporting mods explicitly
  • The explanatory text mentions supported-by explicitly
  • The column header now just says "Related mod" since there are several different relationships
  • The checkbox just says "(De-)select all" instead of specifying a relationship
  • The "Supported By" header now clarifies "(not endorsed by chosen mods)", to set the expectation that this section is not generated from or owned by the mods the user selected

image

The German UI is updated as well.

@HebaruSan HebaruSan added Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request Relationships Issues affecting depends, recommends, etc. labels Apr 4, 2020
@DasSkelett
Copy link
Member

👍. Gonna update the German translation and do a PR to your branch shortly

@DasSkelett
Copy link
Member

Done in HebaruSan#10

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should clear it up a bit!

@HebaruSan HebaruSan merged commit 952f052 into KSP-CKAN:master Apr 23, 2020
@HebaruSan HebaruSan deleted the fix/supports-ui branch April 24, 2020 19:56
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants