Suppress exceptions for non-indexed mods

[HebaruSan]

Problem

ConsoleUI users who had installed CountryDoggosRandomKKBits see this exception as of KSP-CKAN/NetKAN#8711 and KSP-CKAN/CKAN-meta#3283:

Unhandled Exception:
CKAN.ModuleNotFoundKraken: Module not found: CountryDoggosRandomKKBits
  at CKAN.Registry.getAvail (System.String identifier) [0x00040] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.Registry.LatestCompatibleGameVersion (System.Collections.Generic.List`1[T] realVersions, System.String identifier) [0x0000d] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.ModListScreen+<>c__DisplayClass0_0.<.ctor>b__34 (CKAN.CkanModule m) [0x00016] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.Toolkit.ConsoleListBox`1[RowT].Draw (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Boolean focused) [0x00259] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Draw (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x0002e] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Interact (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x0000f] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Run (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Action`1[T] process) [0x00021] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.ConsoleCKAN..ctor (CKAN.GameInstanceManager mgr, System.String themeName, System.Boolean debug) [0x000b1] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.ConsoleUI.ConsoleUI.Main_ (CKAN.GameInstanceManager manager, System.String themeName, System.Boolean debug) [0x00005] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.CmdLine.MainClass.ConsoleUi (CKAN.GameInstanceManager manager, CKAN.CmdLine.ConsoleUIOptions opts) [0x00033] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.CmdLine.MainClass.RunSimpleAction (CKAN.CmdLine.Options cmdline, CKAN.CmdLine.CommonOptions options, System.String[] args, CKAN.IUser user, CKAN.GameInstanceManager manager) [0x002ea] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.CmdLine.MainClass.Execute (CKAN.GameInstanceManager manager, CKAN.CmdLine.CommonOptions opts, System.String[] args) [0x002b4] in <5619c0490fe14ea1b83e6c508f8301de>:0
  at CKAN.CmdLine.MainClass.Main (System.String[] args) [0x000e9] in <5619c0490fe14ea1b83e6c508f8301de>:0

Cause

In #3904, Registry.LatestCompatibleGameVersion was changed from never throwing exceptions:

CKAN/Core/Registry/Registry.cs

Lines 717 to 725 in 7ddc0ed

	/// <summary>
	/// Return the latest game version compatible with the given mod.
	/// </summary>
	/// <param name="identifier">Name of mod to check</param>
	public GameVersion LatestCompatibleGameVersion(List<GameVersion> realVersions,
	string identifier)
	=> available_modules.TryGetValue(identifier, out AvailableModule availMod)
	? availMod.LatestCompatibleGameVersion(realVersions)
	: null;

To possibly throwing ModuleNotFoundKraken via getAvail if the identifier wasn't indexed:

CKAN/Core/Registry/Registry.cs

Lines 676 to 683 in 2fc36b4

	/// <summary>
	/// Return the latest game version compatible with the given mod.
	/// </summary>
	/// <param name="identifier">Name of mod to check</param>
	public GameVersion LatestCompatibleGameVersion(List<GameVersion> realVersions,
	string identifier)
	=> getAvail(identifier).Select(am => am.LatestCompatibleGameVersion(realVersions))
	.Max();

ConsoleUI uses that function as if its failure mode is to return null, not throw an exception:

CKAN/ConsoleUI/ModListScreen.cs

Lines 55 to 59 in 2fc36b4

	}, new ConsoleListBoxColumn<CkanModule>() {
	Header = Properties.Resources.ModListMaxGameVersionHeader,
	Width = 20,
	Renderer = m => registry.LatestCompatibleGameVersion(game.KnownVersions, m.identifier)?.ToString() ?? "",
	Comparer = (a, b) => registry.LatestCompatibleGameVersion(game.KnownVersions, a.identifier).CompareTo(registry.LatestCompatibleGameVersion(game.KnownVersions, b.identifier))

CountryDoggosRandomKKBits is no longer indexed, so now that exception is being thrown and not caught.

Changes

• Now Registry.LatestCompatibleGameVersion doesn't throw ModuleNotFoundKraken anymore, as it was originally
• Now the value of Registry.ProvidedByInstalled is cached while the installed mods remain the same to slightly improve performance, as suggested by a TODO comment long ago

Fixes #4169.