Autodump water, oxygen #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set fuel cells to always dump water, and KO2 scrubbers to always dump oxygen. Forgetting to set resource dumping is a major trap for new players, and this avoids any possible bugs with kerbalism forgetting to dump (if those haven't been fixed yet). Although there are potentially niche scenarios in which the player would not want this to happen, breaking those are preferable to the fuel cell and KO2 scrubber not functioning as expected 99% of the time.
|
This is an easy win. I notice there's a couple other places where we have dump_valve, should those change? Merging this for now. |
|
Potentially. As mentioned, there are scenarios where you might not want to dump excess. A better solution would be to be able to set default dump behavior, and fix the bugs in kerbalism, but that may not be possible considering the development status of kerbalism. |
|
fwiw, I've been running with this fuel cell fix for several years and never ran across a case where it was the wrong thing to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set fuel cells to always dump water, and KO2 scrubbers to always dump oxygen.
Forgetting to set resource dumping is a major trap for new players, and this avoids any possible bugs with kerbalism forgetting to dump (if those haven't been fixed yet).
Although there are potentially niche scenarios in which the player would not want this to happen, breaking those are preferable to the fuel cell and KO2 scrubber not functioning as expected 99% of the time.