Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rxHome and txHome from the jobs #42

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

eggrobin
Copy link
Collaborator

@eggrobin eggrobin commented Aug 18, 2024

use [tr]xIsTracking or [tr]xInAtmosphere as appropriate.

Fix #38.

@eggrobin eggrobin changed the title Remove rxHome and txHome from the jobs, … Remove rxHome and txHome from the jobs Aug 18, 2024
@Capkirk123
Copy link
Member

Capkirk123 commented Aug 19, 2024

This does not appear to actually fix #38?

It does do something, body noise appears to be calculated for everything, including vessels in orbit, as demonstrated by this screenshot, but it also causes atmospheric noise to not be calculated.
image
Skopos stations do at least now have body noise?
image

For reference, this is what working atmospheric noise should look like
image
And this is the current state of Skopos ground stations
image

Edit: on further observation Skopos stations already had body noise. All this does is break atmospheric noise calcs for everything?

@Capkirk123
Copy link
Member

image
Much better. Reasonable atmospheric noise values appear to be applied to Skopos and normal ground stations alike.

@eggrobin eggrobin merged commit 8d79855 into KSP-RO:master Aug 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skopos ground stations have no atmosphere/pointing noise applied
2 participants