Recommendation suppression property for netkans #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HebaruSan Question on this--is it safe to merge now or will CKAN choke on the new property, prior to next client release? |
|
Hi @NathanKell, all three are safe to merge now (referencing KSP-RO/RP-1#2233 and KSP-RO/RP-1-ExpressInstall-Graphics#4), and should be merged before the next CKAN release (timeline uncertain, but maybe 2 weeks?) to minimize disruption. |
|
Awesome thank you, I'll merge these along with other netkan updates and hit the other repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is a pending follow-up item for KSP-CKAN/CKAN#3892.
Sometime in the next 3 months or so, there will most likely be a new CKAN client release featuring "deep recommendations", where all the dependencies in a changeset will contribute recommendations and suggestions, instead of just what the user clicks on.
This pull request applies the
suppress_recommendationsproperty to suppress this behavior for affected KSP-RO netkans.Cheers!