Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature idea : integrate Making Less History into KSPCF #218

Closed
kurgut opened this issue Mar 20, 2024 · 2 comments
Closed

Feature idea : integrate Making Less History into KSPCF #218

kurgut opened this issue Mar 20, 2024 · 2 comments
Labels
kspPerformance Possible performance improvement in KSP kspQoL Quality of life modification

Comments

@kurgut
Copy link

kurgut commented Mar 20, 2024

This mod still works in 1.12, but I believe it would be nice to have its featues integrated in KSPCF, since it improves performances. Plus the said mod is only marked compatible to 1.7.3, which makes it much less visible to the player base.
MLH repo here : https://github.com/DMagic1/KSP_MakingLessHistory

Would need to ask DMagic about it of course.

Thank you : )

@gotmachine gotmachine added kspQoL Quality of life modification kspPerformance Possible performance improvement in KSP labels Mar 22, 2024
@gotmachine
Copy link
Contributor

I'm not against having such a feature, but with the following caveats :

  • KSPCF is a big bag of stuff and users never read through everything it does before installing it, so the usual policy is to avoid doing anything that deviate from stock behavior. Therefore, this should be a disabled by default option, and I'm not too keen on having it as another annoying blocking popup asking for that choice on loading (even if it's a one time popup), in which case this will end up being not very discoverable for the vast majority of users.
  • Independently of how this is handled, we should advertise explicitly that this effectively disable all the expansion features, including the additional launch sites.
  • I don't like how this is implemented in MakingLessHistory, by temporarily renaming a file on the user drive. This can lead to the expansion being permanently disabled, typically in the scenario where KSP crashes or hangs at any time during loading, leading the user to uninstall MakingLessHistory (as removing recently installed mods is the usual thing to do in such a case), leaving the KSP install with a permanently disabled expansion. If such a feature is to be added to KSPCF, the likely best way to do it would be by patching the ExpansionsLoader.InitializeExpansion() coroutine, breaking from it immediately if the string expansionFile argument is matching the MH expansion file.

@gotmachine
Copy link
Contributor

Implemented in 1.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kspPerformance Possible performance improvement in KSP kspQoL Quality of life modification
Development

No branches or pull requests

2 participants